Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of fixes from the NREL branch #737

Open
wants to merge 11 commits into
base: single_tenant_app_snapshot_unmaintained
Choose a base branch
from

Conversation

shankari
Copy link
Contributor

Including:

  • random token for login
  • demographic survey with kobotoolbox
  • go to the diary directly
  • allow users to enter a prior token in the login screen
  • improved trip matching

- Launch a survey
- Autogenerate a random token
- Change the text on the login page
- Display the random token for the user to enter
  - Once we have the newer version of emTripLog, we can set this automatically
Finally we get to use the new `setPromptedAuthToken` method.

This raises a bunch of new questions:
- if the user switches phones or uninstalls + reinstalls, how do they enter their old token?
- how do they write their old token down
- should we give them a choice between autogenerated and human generated

Fortunately, since this is going to collect data for 2-3 days, none of these
need to be answered right now.
This allow users to answer the survey in-app even if they are not able to
respond to the push notification in real time

Testing done:
- Launched the app
- Clicked on the button
- Confirmed that the weekly survey was launched
+ add a button to launch the survey from the profile so current users can fill it in

Testing done:
- launched survey during onboarding + from the profile screen
- confirmed with Bingrong that the UUID was filled in

This partially fixes
e-mission/e-mission-docs#587

Full fix will involve updating the documentation
Avoids race conditions and confusion; highlights the diary
We may want to merge this to master based on feedback from the CEO project
Can change this based on feedback from initial testers
While matching user inputs on the server, found that user input matching was
broken for some cleaned trips on the phone.
e-mission/e-mission-docs#476 (comment)

Expanded the user input end check to fix.
e-mission/e-mission-docs#476 (comment)

Will merge into master after additional testing on the branch.

+ bump up the allowed delta to 15 minutes since the time threshold default for
the distance filter is 10 minutes.
The enhanced trip matching (75129db) caused a
regression in which a spurious trip (not a trip) that occurred after the real
trip fit the criteria for a match.

And since it was confirmed after the real trip, as you would expect while going
down the trip list, it was matched preferentially.
e-mission/e-mission-docs#476 (comment)

Fixed by checking the degree over overlap and rejecting too short matches
to be consistent with the refactor in
21ab3fa
and
6bd731a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant